-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fulu definition #7479
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
packages/beacon-node/test/unit/chain/lightclient/upgradeLightClientHeader.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7479 +/- ##
============================================
- Coverage 50.48% 50.47% -0.01%
============================================
Files 602 603 +1
Lines 40606 40656 +50
Branches 2230 2231 +1
============================================
+ Hits 20499 20523 +24
- Misses 20067 20093 +26
Partials 40 40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like CI is happy which is good enough for now
looks like E2E tests are broken...didn't see that, we are missing |
**Motivation** Whoops.... that was failing on the last merge #7479 --------- Co-authored-by: Nico Flaig <[email protected]>
We accidentally scheduled fulu on sepolia in #7479, it uses the same fork epoch as electra. This means our unstable branch is not able to sync the network right now.
Motivation
Both
peerDAS
andFOCIL
both rely on these changes and its little harm to merge them into unstable so that both branches can build on this without diverging.