fix: peerDAS - fix mismatch error when downloading columns at synced time

[twoeths]

Motivation

• fix this mismatch error at synced time

^[[39m: matchBlockWithDataColumns2 dataColumnIndexes=11 15, reque        stedColumnsPresent=false, slot=38584, peerClient=Lighthouse-cgc:128
2609158 Feb-12 18:58:44.857[sync]            ^[[34mdebug^[[39m: Missing or mismatching dataColumnSidecars from peerId=16U        iu2HAmJyaVGkRGR9ACqompkoge8T2x4KFH4KbzDkh7zz6uN2JX for blockSlot=38584 with numColumns=8 dataColumnSidecars=2 req        uestedColumnsPresent=false received dataColumnIndexes=11 15 requested=11 15 65 71 72 73 83 108 allBlocks=1, allDa        taColumnSidecars=2, peerId=16Uiu2HAmJyaVGkRGR9ACqompkoge8T2x4KFH4KbzDkh7zz6uN2JX, nodeId=0x70a752f736fd0254c715ae        31a3b64d9f3e011c1ca38e7f828d6d7f7bdf4391aa, blobKzgCommitmentsLen=6, peerClient=Lighthouse-cgc:128

• this is the logic inside unavailableBeaconBlobsByRootPostFulu()

Description

• at gossip time, unavailableBeaconBlobsByRootPostFulu() call range sync's matchBlockWithDataColumns() which is a mistake because we should not expect peer has enough columns for us at gossip time. Spec: https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#datacolumnsidecarsbyroot-v1
• instead of that, just get as much columns as we can and return data promise at that time
• more details: bring matchBlockWithDataColumns() logic without matching code

[twoeths]

this works as expected. It shows that either availability input is returned, or data promise input in return and need to take some more rounds with other peers to download missing columns

2025-02-14 12:10:32.332 | Feb-14 05:10:32.319[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48843, requestedColumns=11,83, respondedColumns=11,83, peerClient=Lighthouse-cgc:128 |  
-- | -- | --
  |   | 2025-02-14 12:10:11.931 | Feb-14 05:10:11.931[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48841, requestedColumns=72,73,83, respondedColumns=72,73,83, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 12:10:11.614 | Feb-14 05:10:11.614[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48841, requestedColumns=72,73,83, respondedColumns=, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 12:05:08.818 | Feb-14 05:05:08.818[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48816, requestedColumns=65,71,72,73,83,108, respondedColumns=65,71,72,73,83,108, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 12:04:34.078 | Feb-14 05:04:34.078[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48813, requestedColumns=11,15,71,72,83,108, respondedColumns=11,15,71,72,83,108, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 12:04:32.409 | Feb-14 05:04:32.409[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48813, requestedColumns=11,15,71,72,83,108, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 12:03:59.782 | Feb-14 05:03:59.782[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48810, requestedColumns=, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 12:03:56.436 | Feb-14 05:03:56.436[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48810, requestedColumns=65, respondedColumns=65, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 12:02:56.818 | Feb-14 05:02:56.818[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48805, requestedColumns=71,72,73,108, respondedColumns=71,72,73,108, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 12:02:20.074 | Feb-14 05:02:20.074[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48802, requestedColumns=71, respondedColumns=71, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 12:01:59.880 | Feb-14 05:01:59.880[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48800, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=11,15,65,71,72,73,83,108, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 12:01:56.077 | Feb-14 05:01:56.077[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48800, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:59:32.649 | Feb-14 04:59:32.649[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48788, requestedColumns=11,71,72,73,108, respondedColumns=11,71,72,73,108, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:58:56.073 | Feb-14 04:58:56.073[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48785, requestedColumns=108, respondedColumns=108, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:56:58.477 | Feb-14 04:56:58.477[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48775, requestedColumns=, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:56:57.578 | Feb-14 04:56:57.577[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48775, requestedColumns=, respondedColumns=, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:56:56.652 | Feb-14 04:56:56.652[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48775, requestedColumns=11,71,73,83, respondedColumns=11,71,73,83, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:56:08.220 | Feb-14 04:56:08.219[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48771, requestedColumns=11,65,71,83,108, respondedColumns=11,65,71,83,108, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:55:46.876 | Feb-14 04:55:46.876[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48769, requestedColumns=73,83,108, respondedColumns=73,83,108, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:55:12.041 | Feb-14 04:55:12.041[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48766, requestedColumns=71,72,73,108, respondedColumns=, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:54:20.275 | Feb-14 04:54:20.275[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48762, requestedColumns=83, respondedColumns=83, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:54:20.217 | Feb-14 04:54:20.217[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48762, requestedColumns=83, respondedColumns=, peerClient=Lodestar-cgc:128 |  
  |   | 2025-02-14 11:53:58.089 | Feb-14 04:53:58.089[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48760, requestedColumns=83,108, respondedColumns=83,108, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:53:57.771 | Feb-14 04:53:57.771[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48760, requestedColumns=65,71,72,73,83,108, respondedColumns=65, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:53:57.427 | Feb-14 04:53:57.427[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48760, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:53:56.800 | Feb-14 04:53:56.800[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48760, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:53:56.587 | Feb-14 04:53:56.587[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48760, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:53:56.376 | Feb-14 04:53:56.375[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48760, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:53:56.318 | Feb-14 04:53:56.318[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48760, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:53:08.612 | Feb-14 04:53:08.612[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48756, requestedColumns=15,65,71,72,73,83,108, respondedColumns=15,65,71,72,73,83,108, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:47:56.319 | Feb-14 04:47:56.319[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48730, requestedColumns=15,65,73,83, respondedColumns=15,65,73,83, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:47:44.059 | Feb-14 04:47:44.059[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48729, requestedColumns=15, respondedColumns=15, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:42:44.119 | Feb-14 04:42:44.119[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48704, requestedColumns=, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:42:32.212 | Feb-14 04:42:32.212[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48703, requestedColumns=15, respondedColumns=15, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:41:33.037 | Feb-14 04:41:33.037[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48698, requestedColumns=71, respondedColumns=71, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:39:32.332 | Feb-14 04:39:32.317[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48688, requestedColumns=11,71,83, respondedColumns=71,83,11, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:37:46.442 | Feb-14 04:37:46.442[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48679, requestedColumns=, respondedColumns=, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:37:46.058 | Feb-14 04:37:46.058[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48679, requestedColumns=, respondedColumns=, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:37:45.221 | Feb-14 04:37:45.221[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48679, requestedColumns=65,73,83,108, respondedColumns=73,65,108,83, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:37:32.192 | Feb-14 04:37:32.192[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48678, requestedColumns=15, respondedColumns=15, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:32:44.830 | Feb-14 04:32:44.830[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48654, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=11,15,65,71,72,73,83,108, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:32:44.407 | Feb-14 04:32:44.407[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48654, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:30:44.143 | Feb-14 04:30:44.143[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48644, requestedColumns=11,71,72,83, respondedColumns=11,71,72,83, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:29:32.108 | Feb-14 04:29:32.108[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48638, requestedColumns=15,73,108, respondedColumns=15,73,108, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:29:20.614 | Feb-14 04:29:20.614[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48637, requestedColumns=72,83,108, respondedColumns=72,83,108, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:24:11.214 | Feb-14 04:24:11.213[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48611, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=11,15,65,71,72,73,83,108, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:24:08.784 | Feb-14 04:24:08.784[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48611, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Teku-cgc:128 |  
  |   | 2025-02-14 11:24:08.378 | Feb-14 04:24:08.378[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48611, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Lighthouse-cgc:128 |  
  |   | 2025-02-14 11:24:08.320 | Feb-14 04:24:08.320[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Still missing data columns for block slot=48611, requestedColumns=11,15,65,71,72,73,83,108, respondedColumns=, peerClient=Nimbus-cgc:128 |  
  |   | 2025-02-14 11:17:34.719 | Feb-14 04:17:34.719[sync]          verbose: unavailableBeaconBlobsByRootPostFulu: Resolved availability for block with all data columns slot=48578, requestedColumns=15,65,71,72,73,83,108, respondedColumns=65,72,15,83,73,71,108, peerClient=Teku-cgc:128

[matthewkeil]

LGTM 🚀