Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APIS-874] CUBRID Linux ODBC #81

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

[APIS-874] CUBRID Linux ODBC #81

wants to merge 21 commits into from
+796 −14

Conversation

kisoo-han
Copy link
Contributor

@kisoo-han kisoo-han commented Jan 23, 2025 •
edited
Loading

http://jira.cubrid.org/browse/APIS-874

Description

  • Linux ODBC 빌드를 위한 기본 file을 update/upload 합니다.

Remarks

  • 현재 상태에서의 빌드
   $ cd cubrid-udbc
   $ git submodule init
   $ git submodule update
   $ cd cci-src
   $ sh build.sh
   $ cd ..
   $ cmake CMakeLists.txt
   $ make

@kisoo-han kisoo-han self-assigned this Jan 23, 2025
@kisoo-han kisoo-han requested a review from hwany7seo January 23, 2025 06:55
@kisoo-han kisoo-han changed the title [APIS-874] add CMakeLists.txt for Linux ODBC build [APIS-874] CUBRID Linux ODBC Feb 8, 2025
@kisoo-han kisoo-han marked this pull request as ready for review February 11, 2025 09:00
hwany7seo
hwany7seo approved these changes Mar 10, 2025
View reviewed changes
odbc_interface.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Windows headers are still included in Linux builds.

Copy link
Contributor Author

@kisoo-han kisoo-han Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You right, it seems my mistake, "#include <windows.h>" is excluded from obdc_interface.c.
분명 size 0의 windows.h를 지우고 빌드 테스트를 했는데 왜 빠졌을까 생각했는데,
odbc_interface를 수정은 했는데 commit에서 빠졌더라구요. 세심한 review 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwany7seo hwany7seo hwany7seo approved these changes

Assignees

@kisoo-han kisoo-han

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kisoo-han @hwany7seo