Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Issue of removing slashes (' - ') from incoming date on OBX-4 #17512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abiphilipnava
Copy link
Collaborator

This PR ...

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Test using FHIR Command line with input file and set output file location

Changes

  • Modified simple-report-sender-transform.yml to incorporate transform code for date issue

Checklist

Testing

  • [x ] Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@abiphilipnava abiphilipnava added the onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. label Mar 7, 2025
@abiphilipnava abiphilipnava self-assigned this Mar 7, 2025
@abiphilipnava abiphilipnava requested a review from a team as a code owner March 7, 2025 23:25
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Test Results

1 287 tests  ±0   1 283 ✅ ±0   7m 31s ⏱️ - 1m 6s
  168 suites ±0       4 💤 ±0 
  168 files   ±0       0 ❌ ±0 

Results for commit 7f19a8a. ± Comparison against base commit b220271.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 8, 2025

Integration Test Results

 60 files   60 suites   43m 27s ⏱️
428 tests 400 ✅ 10 💤 18 ❌
431 runs  403 ✅ 10 💤 18 ❌

For more details on these failures, see this check.

Results for commit 7f19a8a.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants