All instances of HashMap and HashSet now deterministic.
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJacobsonCDC
force-pushed
the
RobertJacobsonCDC_222_use_deterministic_hash
branch
2 times, most recently
from
20e9baf to
d56dfba
Compare
This was referenced Mar 11, 2025
…ot so that it is easy to replace implementation. Deterministic implementations of both data structures are provided in `hashing.rs`. The same deterministic algorithm is used in `random.rs` for name offset in RNGs. Fixed a big in `get_rng()` where adding the seed offset might saturate. Allowed "implicit hasher" for clippy.
RobertJacobsonCDC
force-pushed
the
RobertJacobsonCDC_222_use_deterministic_hash
branch
from
d56dfba to
c400972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All instances of
HashMapandHashSetnow import from the crate root so that it is easy to replace implementation.Deterministic implementations of both data structures are provided in
hashing.rs.The same deterministic algorithm is used in
random.rsfor name offset in RNGs.Fixed a bug in
get_rng()where adding the seed offset might saturate.Allowed "implicit hasher" for clippy.
This PR addresses the following issues: