Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:[DEV-10561] update bar labels with CI #1973

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

Atash3000
Copy link
Collaborator

[Replace With Ticket Number]

Testing Steps

Open Bar chart
Add CI keys
Add labels for bars
When CI is on bar labels should be on right side of bar as shown in the image.
when there are many bars the labels will be overlap but thats find as 508 approved it.
Screenshot 2025-02-28 at 12 32 30

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@Atash3000 Atash3000 added this to the 4.25.3 milestone Feb 28, 2025
Copy link
Collaborator

@adamdoe adamdoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atash3000 the ticket asked for above the CI or at the bottom of the bar in the description field:

It would be great if you could choose an alternate placement for this label (such as the bottom of the bar) or if they could hover above the confidence interval.

I know when we discussed horizontal charts those were impacted as well. I think clarifying the impacted charts and where the labels should appear in the next standup would be beneficial.

Also, I think we should get a story created that shows both scenarios.

@Atash3000
Copy link
Collaborator Author

@adamdoe later Sharon Turner sent request to put labels in right hand side for CI bars.I will create a story for this.

@Atash3000
Copy link
Collaborator Author

@adamdoe added story for Templates/Chart/Confidence Interval/Bar chart with labels. also added Line chart CI to that folder to make it orginized.

@Atash3000 Atash3000 requested a review from adamdoe March 12, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants