Fix [DEV-9150] Fix double chart request #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mgetz10
approved these changes
Mar 6, 2025
Atash3000
added a commit
that referenced
this pull request
Mar 7, 2025
* [DEV-10447] Add feature to hide title on Data-Bite * Bump dompurify from 3.1.5 to 3.2.4 (#1965) * Bump nanoid from 3.3.7 to 3.3.8 (#1779) Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Publish - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] * Publish - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] * Publish - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] - @cdc/[email protected] * Bump dompurify from 3.1.5 to 3.2.4 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.1.5 to 3.2.4. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.1.5...3.2.4) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Doe <[email protected]> * [viewport-issue] Fixed spelling (#1953) * [DEV-10422] update COVE help links (#1943) * Remove extra data request from charts (#1971) * feature [DEV-10067]: update dropdown and buttons styles to match UX document (#1978) * wip: update dropdown and buttons styles * fix: apply text and clear filters button functionality * FIX:[DEV-9662] Handle Line chart append text (#1969) * [DEV-9662] Handle Line chart append text * [DEV-9662] Add guards to CI * [DEV-9662] Update colors * [DEV-9662] add guards --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adam Doe <[email protected]> Co-authored-by: Jay Boice <[email protected]> Co-authored-by: Monroe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEV-9150]
This removes a double data request for charts that load remote data via a
dataUrl.It's not clear to me what situation this
loadDataFromConfigfunction is needed. It only loads remote data when 1) there's adataUrland 2) there are no url filters, but then this useEffect in CDCChartComponent also loads the remote data in that situation.In my testing I didn't find any configurations where it's needed, but it's possible I missed something.
Testing Steps
sample config
Load a
dataUrlchart locally. On thedevbranch, there will be two network requests for the data file in the network tab, on this branch there will be one.Ensure that the change does not break any other configurations, like dashboards, charts without
dataUrl, etc.Self Review
Screenshots (if applicable)
Additional Notes