fix dev-10575 dev-10566 performance improvement #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlacey
commented
Feb 25, 2025
| @@ -93,7 +108,7 @@ const EditorPanel = memo(props => { | |||
| } | |||
|
|
|||
| const convertStateToConfig = () => { | |||
| let strippedState = JSON.parse(JSON.stringify(config)) | |||
| let strippedState = _.cloneDeep(config) | |||
There was a problem hiding this comment.
This is the only code change, everything else is formatter
adamdoe
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Replace With Ticket Number]
Testing Steps
The tests in the tickets will ultimately need to be run on wp-test. There were some issues with long load times with the apis which surfaced some state logic issues after the data responses set new states but user navigated away from the current action.
Additionally, I noticed that there was a performance delay on some of the apps due to JSON.stringify(JSON.parse(config)) when used in the dashboard. Multiple visualizations were using this and all together it was causing the app to be slow when switching between tabs.
Self Review
Screenshots (if applicable)
Additional Notes