Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves the default value of the analytics host to helm charts #673

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

adamloup-enquizit
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit commented Dec 12, 2024

I am removing the default values of properties that deal with external services from the modernization-api configuration so that they are in one place in the helm charts.

The change from https://us.posthog.com to https://us.i.posthog.com is intentional, the host name for capturing events was changed in the documentation.

Copy link
Collaborator

@szamfir szamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamloup-enquizit adamloup-enquizit merged commit b924b03 into main Dec 12, 2024
2 checks passed
@adamloup-enquizit adamloup-enquizit deleted the defaults/posthog branch December 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants