Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets: remove all references to getBuilderSearchParams #3954

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samijaber
Copy link
Contributor

Description

As per https://builder-io.atlassian.net/browse/ENG-8635?focusedCommentId=28672 we want to remove this helper from our snippets as it's unneeded.

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 40534bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@builder.io/sdk-angular Patch
@builder.io/sdk-react-nextjs Patch
@builder.io/sdk-qwik Patch
@builder.io/sdk-react Patch
@builder.io/sdk-react-native Patch
@builder.io/sdk-solid Patch
@builder.io/sdk-svelte Patch
@builder.io/sdk-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Mar 6, 2025

View your CI Pipeline Execution ↗ for commit 40534bc.

Command Status Duration Result
nx test @snippet/nextjs-sdk-next-app ❌ Failed 4m 58s View ↗
nx test @snippet/hydrogen ❌ Failed 3m 11s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m View ↗
nx test @e2e/qwik-city ✅ Succeeded 8m 3s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 43s View ↗
nx test @e2e/vue ✅ Succeeded 5m 1s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 5m 58s View ↗
nx test @e2e/sveltekit ✅ Succeeded 5m 20s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-06 19:57:53 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant