Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[remix][gen2]: add remix gen2 snippets #3910

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

murrayadam
Copy link

  • Add new React Router (Remix v3) page snippet.
  • Integrate into CI for testing

https://builder-io.atlassian.net/browse/ENG-8343

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: a3a385d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Feb 12, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret 827da34 packages/sdks/snippets/remix/app/routes/builder-page.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're missing running yarn to install and update the monorepo

@murrayadam
Copy link
Author

@samijaber I just committed the updated yarn.lock.

Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit a3a385d.

Command Status Duration Result
nx test @snippet/remix ❌ Failed 13m 1s View ↗
nx test @e2e/react-sdk-next-pages ❌ Failed 5m 35s View ↗
nx test @snippet/react-sdk-next-pages ❌ Failed 3m 43s View ↗
nx test @e2e/qwik-city ✅ Succeeded 8m 50s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m 49s View ↗
nx test @e2e/angular-16 ✅ Succeeded 8m 16s View ↗
nx test @e2e/nuxt ✅ Succeeded 8m 14s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 8m 4s View ↗
Additional runs (35) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-02-28 20:45:41 UTC

"scripts": {
"build": "react-router build",
"dev": "react-router dev",
"start": "react-router-serve ./build/server/index.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a serve command for tests to run

Suggested change
"start": "react-router-serve ./build/server/index.js",
"start": "react-router-serve ./build/server/index.js",
"serve": "yarn start",

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the NextJS Pages tests and snippets are failing. Pne idea is to add the same hoistingLimits: "workspaces" config to the two failing servers package.json:

that might potentially solve some of the failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants