-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[remix][gen2]: add remix gen2 snippets #3910
base: main
Are you sure you want to change the base?
feat[remix][gen2]: add remix gen2 snippets #3910
Conversation
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11707119 | Triggered | Generic High Entropy Secret | 827da34 | packages/sdks/snippets/remix/app/routes/builder-page.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you're missing running yarn
to install and update the monorepo
@samijaber I just committed the updated |
View your CI Pipeline Execution ↗ for commit a3a385d.
☁️ Nx Cloud last updated this comment at |
8e45ec6
to
72feefa
Compare
"scripts": { | ||
"build": "react-router build", | ||
"dev": "react-router dev", | ||
"start": "react-router-serve ./build/server/index.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a serve
command for tests to run
"start": "react-router-serve ./build/server/index.js", | |
"start": "react-router-serve ./build/server/index.js", | |
"serve": "yarn start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the NextJS Pages tests and snippets are failing. Pne idea is to add the same hoistingLimits: "workspaces"
config to the two failing servers package.json:
- https://github.com/BuilderIO/builder/blob/38b6b8692c88c95c700455b0d050c48272f3926e/packages/sdks/snippets/react-sdk-next-pages/package.json
- https://github.com/BuilderIO/builder/blob/38b6b8692c88c95c700455b0d050c48272f3926e/packages/sdks/e2e/react-sdk-next-pages/package.json
that might potentially solve some of the failures
…xt-pages folders.
https://builder-io.atlassian.net/browse/ENG-8343