fix: build python x86_64-linux with an older glibc #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
sxlijin
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request modifies the build process for baml-runtime to be less strict by commenting out a panic statement.
- File Modified:
engine/baml-runtime/build.rs - Key Change: Commented out a panic statement to prevent build failures during development/testing.
- Potential Issue: May miss critical build failures, leading to runtime issues if the environment is not correctly set up.
- Context: Functions to check Ruby version and Clang support remain unchanged, ensuring essential build environment checks are still in place.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
The pull request updates the build process for baml-runtime to support older glibc versions on x86_64-linux.
- File Modified:
engine/baml-runtime/build.rs - Key Change: Adjusted build configuration to target older glibc versions for compatibility.
- Potential Issue: Ensure thorough testing on various environments to confirm compatibility.
- Context: This change aims to broaden the runtime's compatibility with older Linux distributions.
1 file(s) reviewed, no comment(s)
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
No major changes found since the last review.
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.