Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf Dependency Management #1

Closed
moloch-- opened this issue Jan 21, 2019 · 2 comments
Closed

Protobuf Dependency Management #1

moloch-- opened this issue Jan 21, 2019 · 2 comments

Comments

@moloch--
Copy link
Member

the packaged 6github.com.zip containing the protobuf dep was not matching the protoc-gen-go lib I had on my system, and building the agent always failed with the following error:

undefined: proto.ProtoPackageIsVersion3

I had to repackage the dep with a fresher version of the protobuf lib.

@Eriner
Copy link
Contributor

Eriner commented Jan 21, 2019

As a potential fix, check the retcode in the makefile and conditionally execute go get (as done with #4)?

@moloch--
Copy link
Member Author

It's a little tricker than that, we basically need to add it to the go-assets.sh script, this dependency get's zip'd and shipped with the server binary --along with all the Go compiler tool chain, which is how the server is able to dynamically compile new binaries with it's own certs.

moloch-- pushed a commit that referenced this issue Jul 20, 2020
moloch-- pushed a commit that referenced this issue Aug 14, 2020
@ghost ghost mentioned this issue Mar 3, 2021
rkervella added a commit that referenced this issue Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants