only get onError when error occurs
#267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Oct 2, 2017
There was a problem hiding this comment.
I believe this is probably not a path we want to go down. Wrapping all backburner invocations in a try / catch when there is no need seems wasteful (and makes debugging a bit more difficult since the "break on exception" will not hit this BB internals code).
Definitely open to discussion by @stefanpenner / @krisselden here though...
|
when bb used in ember, ember always supplies |
|
@bekzod - That specific issue was fixed in emberjs/ember.js#15600. |
|
closing this in favor of new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just idea, throwing just for discussion