Fix 135 #151
Merged
Fix 135 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,16 @@ export default function Backburner(queueNames, options) { | |||
| end: [], | |||
| begin: [] | |||
| }; | |||
|
|
|||
| var backburner = this; | |||
| this.executeTimers = function () { | |||
There was a problem hiding this comment.
Why not just put this on the prototype
There was a problem hiding this comment.
Because the point is to bind to this so we don't remake the bound function every time.
There was a problem hiding this comment.
are you ok with moving the content of this function to on the prototype?
prototype.executeTimers = function () {
.. content of your function.
}We can then in the constructor do what you just did.
var backburner = this;
this.boundExecuteTimers = function() {
return backburner.executeTimers.bind(backburner);
}Why?
- the function logic is where one would expect it to be.
|
@rwjblue @stefanpenner when tests are green this is merge-able pending review. |
|
tests appear unhappy |
Cleanup timers to make clear what is going on. Simplify based on the fact we are inserting into the _timers in sorted order. Remove multiple sources of truth. Simplify stale timer handling (should we move this check in other spots like run)? Remove duplicate test of hanging issue, the other one with the spin is more reliable.
|
LGTM @stefanpenner - r? |
|
LGTM |
stefanpenner
added a commit
that referenced
this pull request
Sep 11, 2015
|
following up with another quick cleanup PR |
|
follow up pr #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of the tests intermittently fail.
Closes #146
Closes #137
Closes #143
Fixes #135