Remove the second server.listen so that it also works with Node 20.13 #841
+0
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #829
Since Node 20.13, the behavior of
Server.listen
has changed.The last listen will activate.
see: nodejs/node#53204
The SWA CLI used to listen for localhost and listen for localIpAdress (access from the same network), but in Node 18 and 20, the latter listen for localIpAdress does not seem to work anymore.
Only localhost listen is performed under 20.13.
Currently only the latter process is used in Node 20.13 environments, so only localIpAdress access is available.
Therefore, this PR will be adapted to the behavior under Node 20.13 so that it can be accessed by localhost and so on.
I think it is better to consider how to make it accessible via localIpAdress from the same network in a new PR.
Testing with this change can be verified with
npm run e2e:static
. (This is the e2e test that is currently disabled)