Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load staticwebapp.config.json schema locally when timeout #808

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

cjk7989
Copy link
Contributor

@cjk7989 cjk7989 commented Mar 4, 2024

Added a logic to load static-web-apps-cli/schema/staticwebapp.config.json as a backup to solve issue #754 and #802

@cjk7989 cjk7989 merged commit 34864d0 into main Mar 4, 2024
3 of 4 checks passed
@cjk7989 cjk7989 deleted the jikun/fix-schemaUrl-timeout branch March 4, 2024 20:30
"dotnet:6.0",
"dotnet-isolated:6.0",
"dotnet-isolated:7.0",
"node:12",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest platforms seems to be missing compared to Azure Functions:
az functionapp list-runtimes --os linux --query "[].{stack:join(':', [runtime, version]), LinuxFxVersion:linux_fx_version, SupportedFunctionsVersions:to_string(supported_functions_versions[])}" --output table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will investigate the details, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated supported platform "dotnet-isolated:8.0" in PR #809.

@anfibiacreativa
Copy link
Member

Hi @cjk7989 although I agree that this PR at least decouples concerns: 1 thing is not to find the schema, another thing is for the configuration not to conform to the schema.

Can we please revert the previous changes f07e351 on the grounds of: do we really want to block customers from running their applications when there is a misconfiguration? What is the rationale to go from warning to error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants