Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vFix]: For forcing base image tag updates #3833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[vFix]: For forcing base image tag updates #3833

wants to merge 1 commit into from

Conversation

yeshsurya
Copy link
Contributor

@yeshsurya yeshsurya requested a review from a team as a code owner February 11, 2025 14:00
vizhur
vizhur requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@vizhur vizhur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dummy change please

vizhur
vizhur reviewed Feb 11, 2025
View reviewed changes
assets/training/finetune_acft_image/environments/acft_image_huggingface/context/Dockerfile
# dummy number to change when needing to force rebuild without changing the definition: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these lines from the docker context of all your environments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because tag for base image is calculated like : FROM mcr.microsoft.com/aifx/acpt/stable-ubuntu2204-cu118-py310-torch222:{{latest-image-tag:biweekly\.\d{6}\.\d{1}.*}} ; We need to move to latest tag of base image to resolve vulnerabilities ; Can we continue with that dummy change, given we need latest tag ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vizhur vizhur vizhur requested changes

@skasturi skasturi skasturi approved these changes

@novaturient95 novaturient95 novaturient95 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeshsurya @skasturi @vizhur @novaturient95