-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[search] Migrate search projects to use snippets extraction #33265
base: main
Are you sure you want to change the base?
Conversation
API change check API changes are not detected in this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just wondering if vitest obviates the need to avoid arrow functions here :)
@@ -4,74 +4,74 @@ import { odata } from "../../src/index.js"; | |||
import { describe, it, assert } from "vitest"; | |||
|
|||
describe("odata", function () { | |||
it("simple string isn't changed", function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be reverting #23761?
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Updates all projects under
search
to use snippets extraction.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists