Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] Migrate search projects to use snippets extraction #33265

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/search-documents

Issues associated with this PR

Describe the problem that is addressed by this PR

Updates all projects under search to use snippets extraction.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@mpodwysocki mpodwysocki requested review from a team and dgetu as code owners March 3, 2025 16:58
@github-actions github-actions bot added the Search label Mar 3, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@dgetu dgetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if vitest obviates the need to avoid arrow functions here :)

@@ -4,74 +4,74 @@ import { odata } from "../../src/index.js";
import { describe, it, assert } from "vitest";

describe("odata", function () {
it("simple string isn't changed", function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be reverting #23761?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants