Skip to content

[PS] migrate MobileNetwork module to autorest v4 #27813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

JoyerJin
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 02:31
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the MobileNetwork module to autorest v4 by updating model namespaces, help URLs, and parameter configurations. Key changes include renaming types from the legacy Api20221101 namespace to the new model namespace, updating parameter attributes (e.g. using PSArgumentCompleterAttribute), and removing several legacy cmdlet files.

Reviewed Changes

Copilot reviewed 143 out of 143 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/Deploy-AzMobileNetworkReinstallPacketCoreControlPlane.md Updated output type reference to use the new model namespace.
docs/Az.MobileNetwork.md Updated module GUID and standardized command descriptions to lower-case action verbs.
custom/*.ps1 files Renamed model type references, updated parameter attributes (e.g. replacing ArgumentCompleter with PSArgumentCompleterAttribute), and removed deprecated cmdlet files.
README.md Adjusted directives and removed deprecated configuration flags.
Properties/AssemblyInfo.cs Introduced new assembly version and metadata for the updated module.
Comments suppressed due to low confidence (3)

src/MobileNetwork/MobileNetwork.Autorest/custom/Update-AzMobileNetworkService.ps1:99

  • The parameter is aliased as 'ServiceName' but the underlying variable is renamed to 'Name'. Ensure that documentation and downstream cmdlet consumers are updated to reflect this change so that parameter naming remains consistent module-wide.
[Parameter(ParameterSetName='UpdateViaIdentityMobileNetworkExpanded', Mandatory)] [Alias('ServiceName')] [Microsoft.Azure.PowerShell.Cmdlets.MobileNetwork.Category('Path')] [System.String]

src/MobileNetwork/MobileNetwork.Autorest/custom/Update-AzMobileNetworkSlice.ps1:201

  • The previous logic that retrieved the slice and set fallback values (e.g. Description, SnssaiSd, Tag) has been removed in favor of a direct internal update call. Confirm that the new internal update method correctly handles the default parameter values to ensure anticipated behavior during updates.
Az.MobileNetwork.internal\UpdateAzMobileNetworkSlice @PSBoundParameters

src/MobileNetwork/MobileNetwork.Autorest/custom/Update-AzMobileNetworkService.ps1:267

  • The fallback logic that populated missing parameters from the existing service object has been removed. Verify that the new internal update command reliably applies the necessary default values.
Az.MobileNetwork.internal\UpdateAzMobileNetworkService @PSBoundParameters

@msJinLei msJinLei merged commit a9bb83e into main May 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants