[NetAppFiles] Anf 52155 ora volume group

[audunn]

Description

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[msJinLei]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[msJinLei]

  "Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.NetAppFiles","Microsoft.Azure.Commands.NetAppFiles.VolumeGroup.NewAzureRmNetAppFilesVolumeGroup","New-AzNetAppFilesVolumeGroup","1","8410","Parameter NumberOfDataVolumes of cmdlet New-AzNetAppFilesVolumeGroup does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."

[msJinLei]

The parameter names with numbers are not user-friendly. Can you differentiate them with usage rather than numbers?

[msJinLei]

Please use singular name of the parameter NumberOfDataVolume

[audunn]

The data volumes need to have this numbering applied to them

[github-actions]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

[audunn]

@msJinLei please have another look, we need this in the next release.

[msJinLei]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[audunn]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 27783 in repo Azure/azure-powershell

[audunn]

Note this is needed for the next relase.

[msJinLei]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[msJinLei]

@audunn Please fix the failed test case

  [xUnit.net 00:00:15.96]     Microsoft.Azure.Commands.NetAppFiles.Test.ScenarioTests.ScenarioTest.VolumeGroupTests.TestOracleVolumeGroupToManyVolumes [FAIL]
    Failed Microsoft.Azure.Commands.NetAppFiles.Test.ScenarioTests.ScenarioTest.VolumeGroupTests.TestOracleVolumeGroupToManyVolumes [862 ms]
EXEC : error Message:  [D:\a\_work\1\s\build.proj]
     System.Management.Automation.RuntimeException : Expected exception does not contain the expected text 'Cannot validate argument on parameter ', the actual message is 'A parameter cannot be found that matches parameter name 'NumberOfDataVolumes'.'
  ---- System.Management.Automation.RuntimeException : Expected exception does not contain the expected text 'Cannot validate argument on parameter ', the actual message is 'A parameter cannot be found that matches parameter name 'NumberOfDataVolumes'.'
    Stack Trace:
       at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
     at System.Management.Automation.Runspaces.Pipeline.Invoke()
     at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
     at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
     at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
     at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
     at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
     at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
     at System.Management.Automation.PowerShell.Invoke()
     at Microsoft.Azure.Commands.TestFx.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\_work\1\s\tools\TestFx\EnvironmentSetupHelper.cs:line 501
     at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScriptCore(Action setUp, Action`1 contextAction, Action tearDown, String[] scripts) in D:\a\_work\1\s\tools\TestFx\TestManager.cs:line 250
     at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScript(String[] scripts) in D:\a\_work\1\s\tools\TestFx\TestManager.cs:line 216
     at Microsoft.Azure.Commands.NetAppFiles.Test.ScenarioTests.ScenarioTest.VolumeGroupTests.TestOracleVolumeGroupToManyVolumes() in D:\a\_work\1\s\src\NetAppFiles\NetAppFiles.Test\ScenarioTests\VolumeGroup.cs:line 44
     at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
     at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  ----- Inner Stack Trace -----

Refer to https://dev.azure.com/azclitools/public/_build/results?buildId=246544&view=logs&j=b17395f6-68a3-5682-0476-d3f6f1043109&t=f098cad5-2fd2-534b-df25-06e0723952ab

[github-actions]

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.