Skip to content

feat(datamigration): add support for blob to Sql MI identity migrations #27738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gansach
Copy link
Member

@gansach gansach commented May 12, 2025

Description

  • Bumped up REST api spec from 2022-03-30 preview to 2025-03-15-preview
  • Introduced new params to New-AzDataMigrationToSqlManagedInstance cmdlet
    • AzureBlobAuthType
    • AzureBlobIdentityType
    • AzureBlobUserAssignedIdentity <string[]>
      • Had to add a custom wrapper commandlet to input this param as the auto generated param had hashtable type
      • Made this change to adhere to best practices
      • These managed identity input best practices have been implemented autorest/powershell v4, but we encountered a bug while renaming the auto generated param, migrating to autorest/powershell v4 will be taken up as a separate effort.

Scenarios tested

  • AzureBlobAuthType=abc- REJECTED
  • AzureBlobAuthType=null - PASSED (implicit account key)
  • AzureBlobAuthType=ManagedIdentity; AzureBlobIdentityType=null - REJECTED
  • AzureBlobIdentityType=SystemAssigned - PASSED
  • AzureBlobIdentityType=UserAssigned - PASSED
  • AzureBlobIdentityType=abc - REJECTED
  • AzureBlobIdentityType=SystemAssigned,UserAssgined - REJECTED
  • AzureBlobIdentityType=UserAssigned; AzureBlobUserAssignedIdentity=null - REJECTED
  • AzureBlobUserAssignedIdentity=invalid-url - REJECTED
  • AzureBlobUserAssignedIdentity=valid1, valid2 - REJECTED

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Sorry, something went wrong.

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@gansach gansach changed the title Users/gasachdeva/feat/add blob to sql mi identity migrations feat(datamigration): add support for blob to Sql MI identity migrations May 12, 2025
@wyunchi-ms wyunchi-ms closed this May 13, 2025
@wyunchi-ms wyunchi-ms reopened this May 13, 2025
@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

Please fix the failed test cases

@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

wyunchi-ms
wyunchi-ms previously approved these changes May 13, 2025
@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@gansach gansach force-pushed the users/gasachdeva/feat/add-blob-to-sql-mi-identity-migrations branch from f9e26ec to 45a84e4 Compare May 13, 2025 06:22
@wyunchi-ms
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit 3564cb8 into Azure:main May 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants