Skip to content

[Az.ElasticSan]Set parameters BaseSizeTib and ExtendedBaseSizeTib for New-AzElasticSan to be optional #27659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Apr 28, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Sorry, something went wrong.

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

…let `New-AzElasticSan` to be optional.
@EmmaZhu EmmaZhu changed the title Set parameters BaseSizeTib and ExtendedBaseSizeTib for New-AzElasticSan to be optional [Az.ElasticSan]Set parameters BaseSizeTib and ExtendedBaseSizeTib for New-AzElasticSan to be optional Apr 28, 2025
@blueww
Copy link
Member

blueww commented Apr 28, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli self-assigned this Apr 28, 2025
blueww
blueww previously approved these changes Apr 28, 2025
New-AzElasticSan -Name <String> -ResourceGroupName <String> -BaseSizeTiB <Int64>
-ExtendedCapacitySizeTiB <Int64> -Location <String> -SkuName <String> [-SubscriptionId <String>]
[-AvailabilityZone <String[]>] [-PublicNetworkAccess <String>] [-SkuTier <String>] [-Tag <Hashtable>]
New-AzElasticSan -Name <String> -ResourceGroupName <String> -Location <String> -SkuName <String>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to update help description of the 2 parameters to add the default value of them.
You might can check with Xiaogang to see if any easy way to do that.

@dolauli
Copy link
Contributor

dolauli commented Apr 28, 2025

@EmmaZhu Please suppress the breaking change as you do in #27556.

@dolauli
Copy link
Contributor

dolauli commented Apr 28, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 28, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli merged commit d05eb42 into Azure:main Apr 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants