Skip to content

Release for MicrosoftCache.RedisEnterprise - 2025-05-01 PREVIEW #27602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 30, 2025

Conversation

nikitagarg123
Copy link
Contributor

Description

Changelog:

Upgraded api-version tag from 'package-preview-2024-09' to 'package-preview-2025-01'.
Adds support for listing all SKUs a cluster can scale to.
Clustering policy has a new enum: NoCluster.
Powershell : Release for MicrosoftCache.RedisEnterprise - 2025-05-01 PREVIEW

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Sorry, something went wrong.

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@nikitagarg123 nikitagarg123 changed the title new api version changes Release for MicrosoftCache.RedisEnterprise - 2025-05-01 PREVIEW Apr 18, 2025
@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR with following comments.

  1. Only include change of the src/RedisEnterpriseCache in the PR
  2. Please update the changelog file accordingly - https://github.com/nikitagarg123/azure-powershell/blob/redisenterprise-2025-05-01-preview/src/RedisEnterpriseCache/RedisEnterpriseCache/ChangeLog.md

@dolauli dolauli self-assigned this Apr 18, 2025
@nikitagarg123 nikitagarg123 requested a review from dolauli April 18, 2025 08:15
@nikitagarg123
Copy link
Contributor Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27602 in repo Azure/azure-powershell

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@dolauli
Copy link
Contributor

dolauli commented Apr 18, 2025

There is an issue in service side. In swagger, it is customerFacingSizeInGB, while in the response from service, it is customerFacingSizeInGb.

@nikitagarg123, I added the Do Not Merge label for this PR. Please remove it once the issue is resolved so that I can proceed with the review and merge.

@dolauli
Copy link
Contributor

dolauli commented Apr 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 25, 2025

@nikitagarg123 Please fixed the CI failures.

@dolauli
Copy link
Contributor

dolauli commented Apr 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli added Breaking Change Release This PR contains breaking change Do Not Merge 🚫 labels Apr 25, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

Sorry, something went wrong.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Nikita Garg added 2 commits April 25, 2025 15:10
@nikitagarg123
Copy link
Contributor Author

@dolauli I have renamed the parameter that was causing breaking change, could we remove the breaking change label and do not merge label now?

@dolauli
Copy link
Contributor

dolauli commented Apr 28, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the breaking changes:
To 1&2: There are two parameters -GroupNickname <String> -LinkedDatabase <ILinkedDatabase[]> changed from required to optional, which leads the breaking change. Please check whether it is expected. If it is, you may hide the cmdlet through a directive and then add a custom cmdlet in custom folder, in which you may set the DefaultParameterSetName to the previous one.

To 3&4:
Except for parameters, you will also need to change the property name. See here for how to do it.

Nikita Garg added 2 commits April 29, 2025 11:45
@nikitagarg123
Copy link
Contributor Author

nikitagarg123 commented Apr 29, 2025

@dolauli could you help in running the build again, i have done the changes in readme file for breaking changes

@dolauli
Copy link
Contributor

dolauli commented Apr 29, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Contributor

dolauli commented Apr 30, 2025

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@dolauli dolauli removed Do Not Merge 🚫 Breaking Change Release This PR contains breaking change labels Apr 30, 2025
@dolauli dolauli merged commit aa8e500 into Azure:main Apr 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants