Skip to content

chore: Removal of az.codesigning package since its been renamed #27507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

Jaxelr
Copy link
Member

@Jaxelr Jaxelr commented Apr 3, 2025

Description

This PR deletes the az.codesigning module, since its been rebranded into az.trustedsigning on this PR #27332.

cc: @janielMartell

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@dolauli
Copy link
Contributor

dolauli commented Apr 7, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli self-assigned this Apr 7, 2025
@dolauli
Copy link
Contributor

dolauli commented Apr 7, 2025

@Jaxelr Please following the two PRs below to remove the module.
#27161
#27163

@Jaxelr
Copy link
Member Author

Jaxelr commented Apr 7, 2025

@dolauli based on PR #27163, I removed the aforementioned files, except /tools/Tools.Common/SerializedCmdlets/Az.CodeSigning.json since it doesnt exist anymore.

@dolauli
Copy link
Contributor

dolauli commented Apr 8, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dolauli dolauli merged commit 3df698d into Azure:main Apr 8, 2025
1 of 6 checks passed
@Jaxelr Jaxelr deleted the az.codesigning/removal branch April 8, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants