Skip to content

[eng] Update the logic of resource repository in VersionController #27382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 25, 2025

Conversation

wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Mar 19, 2025

Description

  1. Since we only use PSGallery as the remote resource repository for now (Test Gallery is not used now). Remove the logic for getting the repository.
  2. Add logic to support Azure Artifacts in OneBranch. (We will set DEFAULT_PS_REPOSITORY_NAME, DEFAULT_PS_REPOSITORY_URL and SYSTEM_ACCESS_TOKEN in OneBranch pipeline yaml)

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@@ -160,28 +160,6 @@ private static bool GetModuleReadMe(string directory)
/// </summary>
private static void BumpVersions()
{
string targetRepositories = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only PSGallery as remote repository in our local environment

@wyunchi-ms wyunchi-ms changed the title Wyunchi/cfs [eng] Update the logic of resource repository in VersionController Mar 25, 2025
@wyunchi-ms wyunchi-ms marked this pull request as ready for review March 25, 2025 06:09
@wyunchi-ms wyunchi-ms merged commit 9f08955 into main Mar 25, 2025
12 checks passed
@wyunchi-ms wyunchi-ms deleted the wyunchi/cfs branch March 25, 2025 06:24
blueww pushed a commit to wastoresh/azure-powershell that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants