Skip to content

[Storage] Support NFS file share #27366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2025
Merged

[Storage] Support NFS file share #27366

merged 6 commits into from
Mar 24, 2025

Conversation

blueww
Copy link
Member

@blueww blueww commented Mar 18, 2025

The added cmdlet has pass review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1488

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Sorry, something went wrong.

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@blueww blueww force-pushed the nfsdata branch 2 times, most recently from 778986f to 6893030 Compare March 18, 2025 08:43
@blueww
Copy link
Member Author

blueww commented Mar 18, 2025

The PR check fail with exception in static analysis BreakingChange.
Any idea how to resolve this?

  There are failed tasks: BreakingChange
  Write-Error: Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
     at StaticAnalysis.BreakingChangeAnalyzer.CmdletMetadataHelper.CheckForChangedOutputType(CmdletMetadata oldCmdlet, CmdletMetadata newCmdlet, ReportLogger`1 issueLogger) in D:\a\_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\CmdletMetadataHelper.cs:line 231
     at StaticAnalysis.BreakingChangeAnalyzer.CmdletMetadataHelper.CompareCmdletMetadata(List`1 oldCmdlets, List`1 newCmdlets, ReportLogger`1 issueLogger) in D:\a\_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\CmdletMetadataHelper.cs:line 105
     at StaticAnalysis.BreakingChangeAnalyzer.BreakingChangeAnalyzer.RunBreakingChangeChecks(ModuleMetadata oldModuleMetadata, ModuleMetadata newModuleMetadata, ReportLogger`1 issueLogger) in D:\a\_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\BreakingChangeAnalyzer.cs:line 239
     at StaticAnalysis.BreakingChangeAnalyzer.BreakingChangeAnalyzer.Analyze(IEnumerable`1 cmdletProbingDirs, Func`2 directoryFilter, Func`2 cmdletFilter, IEnumerable`1 modulesToAnalyze) in D:\a\_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\BreakingChangeAnalyzer.cs:line 196
     at StaticAnalysis.BreakingChangeAnalyzer.BreakingChangeAnalyzer.Analyze(IEnumerable`1 cmdletProbingDirs, IEnumerable`1 modulesToAnalyze) in D:\a\_work\1\s\tools\StaticAnalysis\BreakingChangeAnalyzer\BreakingChangeAnalyzer.cs:line 66
     at StaticAnalysis.Program.Main(String[] args) in D:\a\_work\1\s\tools\StaticAnalysis\Program.cs:line 189

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@blueww blueww force-pushed the nfsdata branch 2 times, most recently from b10bc4b to 5ce28ed Compare March 24, 2025 05:25
@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

blueww added 5 commits March 24, 2025 15:21

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@notyashhh notyashhh self-assigned this Mar 24, 2025
@notyashhh notyashhh added this to the Az 13.4.0 (04/01/2025) milestone Mar 24, 2025
@notyashhh notyashhh merged commit 428a008 into Azure:main Mar 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants