Skip to content

Quantum v3 to v4 #27282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 3, 2025
Merged

Quantum v3 to v4 #27282

merged 8 commits into from
Apr 3, 2025

Conversation

Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Mar 6, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi
Copy link
Contributor Author

Pan-Qi commented Mar 6, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@Pan-Qi Pan-Qi force-pushed the bernard-upgrade-quantum-to-autorest-v4 branch 2 times, most recently from 410380f to d359e6d Compare March 6, 2025 06:28
@Pan-Qi Pan-Qi force-pushed the bernard-upgrade-quantum-to-autorest-v4 branch from fc82b14 to d9bde82 Compare March 25, 2025 10:20
@Pan-Qi Pan-Qi marked this pull request as ready for review March 25, 2025 11:42
@dolauli dolauli self-assigned this Mar 27, 2025
Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the change log with something like:

Regenerate the module using the latest v4 generator to incorporate the new features added in the v4 generator.

# For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option
use-extension:
"@autorest/powershell": "3.x"

directive:
- where:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the instruction here to update this directive

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@Pan-Qi Pan-Qi force-pushed the bernard-upgrade-quantum-to-autorest-v4 branch from 0f7a1d7 to 96fdd1b Compare March 31, 2025 02:26
@Pan-Qi Pan-Qi force-pushed the bernard-upgrade-quantum-to-autorest-v4 branch from 96fdd1b to 61d5d26 Compare March 31, 2025 03:12
@Pan-Qi Pan-Qi requested a review from dolauli March 31, 2025 03:17
@dolauli dolauli merged commit 536b95f into main Apr 3, 2025
12 checks passed
@dolauli dolauli deleted the bernard-upgrade-quantum-to-autorest-v4 branch April 3, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants