-
Notifications
You must be signed in to change notification settings - Fork 4k
Update publish-AzWebApp
to support pull based deployments.
#27228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR adds support for pull based deployments from a URL with MSI authentication in Publish-AzWebApp by introducing two new parameters: ArchiveURL and PullIdentity.
- ArchivePath is now optional and ArchiveURL is introduced as an alternative artifact source.
- The cmdlet now validates that when deploying from a URL, the deployment type is provided and restricts pull-based MSI deployments to Windows WebApps.
- Updates include changes to the cmdlet implementation, help file adjustments, test additions, and a changelog entry.
Reviewed Changes
File | Description |
---|---|
src/Websites/Websites/Cmdlets/WebApps/PublishAzureWebApp.cs | Updated parameters and deployment logic to support pull based deployments with MSI authentication. |
src/Websites/Websites.Test/ScenarioTests/WebAppTests.cs | Added a test case for pull based deployments with MSI. |
src/Websites/Websites/help/Publish-AzWebApp.md | Revised help documentation to reflect new parameters and usage. |
src/Websites/Websites/ChangeLog.md | Added a changelog entry for the new MSI-based pull deployment feature. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Websites/Websites/Cmdlets/WebApps/PublishAzureWebApp.cs:103
- [nitpick] The variable name 'fileExtention' appears to be misspelled; consider renaming it to 'fileExtension' for clarity.
string fileExtention = Path.GetExtension(ArchivePath);
Hi @dannysongg, The way Azure pipelines run test cases is in the Playback mode. So you need to run the tests locally in 'Record' Mode. After which there will be a new file generated in SessionRecords folder that will contain the session recordings. Follow these steps: Azure Powershell Testing Docs. |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
@notyashhh session recordings have been added |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Add support for pull based deployments from a URL with MSI authentication in
Publish-AzWebApp
. This change adds 2 parameters to enable this feature:ArchiveURL
and-PullIdentity
.Notable Changes:
ArchiveURL
parameterPullIdentity
parameterArchivePath
is no longer a required parameter.ArchivePath
ORArchiveURL
must be provided. If both are provided, ArchivePath will be ignored-PullIdentity
Usage:Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.