Skip to content

Az.Compute - Shallow Replication for GalleryImageVersion #27225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 26, 2025

Conversation

haagha
Copy link
Member

@haagha haagha commented Feb 25, 2025

Description

Resolves https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1474

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Sorry, something went wrong.

PSCmdAssistant and others added 4 commits February 25, 2025 07:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@haagha
Copy link
Member Author

haagha commented Feb 25, 2025

@NoriZC here's the PR created from this #26965

@NoriZC
Copy link
Contributor

NoriZC commented Feb 25, 2025

same requirements as #27224:

  • target this PR to release-2025-03-04.
  • make sure get approved by another Compute team member
  • pass all the pr validations.

Thanks! :)

@haagha
Copy link
Member Author

haagha commented Feb 25, 2025

Hi @NoriZC

same requirements as #27224:

  • target this PR to release-2025-03-04.
  • make sure get approved by another Compute team member
  • pass all the pr validations.

Thanks! :)

Hi @NoriZC the source PR was approved by Theodore. This is only a copy of that PR. Thanks!
#26965 (review)

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

github-actions bot commented Mar 7, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

haagha and others added 5 commits March 24, 2025 07:10
This commit removes a block of code related to an HTTP request for checking DNS name availability. The removed code included the request URI, method, headers, and response body, which indicated a resource not found error (404 status). The remaining code focuses on a different request related to Microsoft.Compute resources.
The property `ReplicationMode` has been removed from the
`PSGalleryImageVersion` class in the
`Microsoft.Azure.Commands.Compute.Automation.Models` namespace.
@haagha haagha requested a review from grizzlytheodore March 25, 2025 16:00
@notyashhh notyashhh changed the base branch from main to release-2025-04-01 March 26, 2025 01:31
@notyashhh notyashhh dismissed grizzlytheodore’s stale review March 26, 2025 01:31

The base branch was changed.

notyashhh
notyashhh previously approved these changes Mar 26, 2025
Copy link
Member

@notyashhh notyashhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @grizzlytheodore

Copy link
Member

@notyashhh notyashhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @grizzlytheodore

@notyashhh notyashhh merged commit 184b451 into release-2025-04-01 Mar 26, 2025
12 checks passed
@wyunchi-ms wyunchi-ms deleted the haagha/shallowreplication branch May 7, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants