Skip to content

[Az.Accounts] Update Connect-AzAccount.md #25982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

mikurii
Copy link

@mikurii mikurii commented Sep 1, 2024

Added information about the MFA enforcement starting in early 2025.
Once enforcement begins, -Credential option will no longer work due to the mandatory MFA.
Reference: https://learn.microsoft.com/en-us/entra/identity/authentication/concept-mandatory-multifactor-authentication

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Sorry, something went wrong.

Added information about the MFA enforcement starting in early 2025
Reference: https://learn.microsoft.com/en-us/entra/identity/authentication/concept-mandatory-multifactor-authentication
Copy link

azure-client-tools-bot-prd bot commented Sep 1, 2024

❌Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Connect-AzAccount 6 1 Invalid_Cmdlet Get-AzUserAssignedIdentity is not a valid command name. Get-AzUserAssignedIdentity -ResourceGroupName 'myResourceGroup' -Name 'myUserAssignedIdentity' Check the spell of Get-AzUserAssignedIdentity.
Connect-AzAccount 6 2 Invalid_Cmdlet Get-AzVM is not a valid command name. Get-AzVM -ResourceGroupName contoso -Name testvm Check the spell of Get-AzVM.
Connect-AzAccount 6 2 Invalid_Cmdlet Update-AzVM is not a valid command name. Update-AzVM -IdentityType UserAssigned -IdentityId $identity.Id Check the spell of Update-AzVM.
❌Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Connect-AzAccount 6 1 Invalid_Cmdlet Get-AzUserAssignedIdentity is not a valid command name. Get-AzUserAssignedIdentity -ResourceGroupName 'myResourceGroup' -Name 'myUserAssignedIdentity' Check the spell of Get-AzUserAssignedIdentity.
Connect-AzAccount 6 2 Invalid_Cmdlet Get-AzVM is not a valid command name. Get-AzVM -ResourceGroupName contoso -Name testvm Check the spell of Get-AzVM.
Connect-AzAccount 6 2 Invalid_Cmdlet Update-AzVM is not a valid command name. Update-AzVM -IdentityType UserAssigned -IdentityId $identity.Id Check the spell of Update-AzVM.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution mikurii! We will review the pull request and get back to you soon.

@msJinLei
Copy link
Contributor

msJinLei commented Sep 3, 2024

@mikurii Thanks for the contribution. @mikefrobbins could you help to review the change, thanks

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions.

Copy link

github-actions bot commented Sep 5, 2024

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@YanaXu
Copy link
Contributor

YanaXu commented Jan 7, 2025

Hi @mikurii,

Please join your github account to Azure org.

@mikurii
Copy link
Author

mikurii commented Jan 7, 2025

Hi @YanaXu , thank you for letting me know!
I followed the URLs you provided, and I suppose the PR is now ready to be merged

@YanaXu
Copy link
Contributor

YanaXu commented Jan 8, 2025

Hi @mikurii, please check the comments from @mikefrobbins.

mikurii and others added 3 commits January 8, 2025 15:14
Co-authored-by: Mike F. Robbins <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Mike F. Robbins <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Mike F. Robbins <[email protected]>
@YanaXu
Copy link
Contributor

YanaXu commented Jan 8, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu YanaXu assigned YanaXu and unassigned mikurii Jan 8, 2025
@mikurii
Copy link
Author

mikurii commented Jan 8, 2025

Hi @YanaXu , I've committed the suggestions by @mikefrobbins (thank you for the reviews and comments!).
I apologize for my belated response; I'm still not very familiar with GitHub.

@YanaXu YanaXu changed the title Update Connect-AzAccount.md [Az.Accounts] Update Connect-AzAccount.md Jan 8, 2025
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. -Credential is used in two login scenarios - ROPC (aka username + password) and service principal. Only ROPC will be blocked by MFA because it's a user principal. We'd like to be clear in the doc.

@YanaXu
Copy link
Contributor

YanaXu commented Jan 8, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jan 9, 2025

Hi @mikurii,

Could you follow the comment of @isra-fel and update the file?
Also, please refer to this commit to resolve the CI failure.

@YanaXu YanaXu removed their assignment Feb 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

Thanks for contributing. -Credential is used in two login scenarios - ROPC (aka username + password) and service principal. Only ROPC will be blocked by MFA because it's a user principal. We'd like to be clear in the doc.

@mikurii For Credential, please refer to the comment above.
Also we have update warning message of ROPC flow, please refer to #27671.
We are going to close the PR and welcome to continue to contribute to our product!

@msJinLei msJinLei closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants