Testing: Refactor signup tests to remove rewire dependency

client/signup/config/flows.js

@@ -291,17 +291,25 @@ function getGuidedToursDestination( destination, dependencies, flowName ) {
 	return getVariantUrl( guidedToursVariant );
 }
 
-export default {
+const Flows = {
 	filterFlowName,
 	filterDestination,
 
 	defaultFlowName: 'main',
 
 	getFlow( flowName ) {
-		return user.get() ? removeUserStepFromFlow( flows[ flowName ] ) : flows[ flowName ];
+		let flow = Flows.getFlows()[ flowName ];
+
+		if ( user.get() ) {
+			flow = removeUserStepFromFlow( flow );
+		}
+
+		return flow;
 	},
 
 	getFlows() {
 		return flows;
 	}
 };
+
+export default Flows;

client/signup/test/fixtures/flows.js

@@ -0,0 +1,21 @@
+export default {
+	main: {
+		steps: [ 'user', 'site' ],
+		destination: '/'
+	},
+
+	account: {
+		steps: [ 'user', 'site' ],
+		destination: '/'
+	},
+
+	other: {
+		steps: [ 'user', 'site' ],
+		destination: '/'
+	},
+
+	filtered: {
+		steps: [ 'user', 'site' ],
+		destination: '/'
+	}
+};

client/signup/test/flows.js

@@ -1,26 +1,36 @@
 /**
  * External dependencies
  */
-var assert = require( 'assert' );
+import assert from 'assert';
+import sinon from 'sinon';
 
 /**
  * Internal dependencies
  */
 import useFilesystemMocks from 'test/helpers/use-filesystem-mocks';
 import useI18n from 'test/helpers/use-i18n';
 import useMockery from 'test/helpers/use-mockery';
+import useFakeDom from 'test/helpers/use-fake-dom';
+import mockedFlows from './fixtures/flows';
 
 describe( 'flows', function() {
-	var flows, user;
+	let flows, user;
 
+	useFakeDom();
 	useFilesystemMocks( __dirname );
 	useI18n();
+
 	useMockery( ( mockery ) => {
 		mockery.registerMock( 'lib/abtest', {
 			abtest: () => ''
 		} );
-		flows = require( 'signup/config/flows' );
+	} );
+
+	before( () => {
 		user = require( 'lib/user' )();
+
+		flows = require( 'signup/config/flows' );
+		sinon.stub( flows, 'getFlows' ).returns( mockedFlows );
 	} );
 
 	it( 'should return the full flow when the user is not logged in', function() {

client/signup/test/utils.js

@@ -1,29 +1,42 @@
 /**
  * External dependencies
  */
-var debug = require( 'debug' )( 'calypso:client:signup:controller-utils:test' ), // eslint-disable-line no-unused-vars
-	sinon = require( 'sinon' ),
-	assert = require( 'assert' );
+import debugModule from 'debug';
+import sinon from 'sinon';
+import assert from 'assert';
 
 /**
  * Internal dependencies
  */
 import useFilesystemMocks from 'test/helpers/use-filesystem-mocks';
 import useI18n from 'test/helpers/use-i18n';
 import useMockery from 'test/helpers/use-mockery';
+import useFakeDom from 'test/helpers/use-fake-dom';
+import mockedFlows from './fixtures/flows';
+
+/**
+ * Module variables
+ */
+const debug = debugModule( 'calypso:client:signup:controller-utils:test' );
 
 debug( 'start utils test' );
 
 describe( 'utils', function() {
-	var flows, utils;
+	let flows, utils;
 
 	useFilesystemMocks( __dirname );
 	useI18n();
+	useFakeDom();
+
 	useMockery( ( mockery ) => {
 		mockery.registerMock( 'lib/abtest', {
 			abtest: () => ''
 		} );
+	} );
+
+	before( () => {
 		flows = require( 'signup/config/flows' );
+		sinon.stub( flows, 'getFlows' ).returns( mockedFlows );
 		utils = require( '../utils' );
 	} );
 
@@ -143,7 +156,7 @@ describe( 'utils', function() {
 		} );
 
 		it( 'should handle arbitrary step section names', function() {
-			var randomStepSectionName = 'random-step-section-' + Math.random();
+			const randomStepSectionName = 'random-step-section-' + Math.random();
 
 			assert.equal( utils.getValidPath( {
 				flowName: 'account',
@@ -154,7 +167,7 @@ describe( 'utils', function() {
 		} );
 
 		it( 'should handle arbitrary step section names in the default flow', function() {
-			var randomStepSectionName = 'random-step-section-' + Math.random();
+			const randomStepSectionName = 'random-step-section-' + Math.random();
 
 			assert.equal( utils.getValidPath( {
 				stepName: 'user',