-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guided Tours: Add Simple Payments Email Tour #24627
Conversation
The tour works as advertised, but it looks like there's 2 other simple payment tours. One in examples and another that appears to be in use. @lsinger what is the suggested maintenance approach here? We want to run another email campaign with a tour. Should we reuse the old tour, as the query param will force the tour to start? |
@jancavan, @apeatling and I noted that we can probably drop the step 3, where we note that you added a payment button, since the user can see that in the editor directly. Step 2 is a little awkward too in that the tour needs to be dismissed manually, but I feel tempted to click on the add dropdown first. If that's the case, the tour sits underneath the dropdown. We probably don't need to address this here, since I think it's a tour quirk, but wanted to note it. |
@gwwar I'd tend to do a new tour, since none of the previous ones were used for an email campaign. Content-wise they might be similar or even the same, but there's value in keeping intentions separate, too, in my opinion. |
In step 1, we have a continue button here which isn't quite right for this case since, the next step is to click on add vs showing the next tip on the same page. I think we need to remove the continue button (what the branch has currently) and add a call to action, probably an explicit sentence to click on the Page add button. We can see a similar pattern in other main tours. After this is done I believe we can 🚢. @lsinger is it enough here to guard the display of this tour with a cc @jancavan |
Yes, @Copons had already reached out about this on Slack. 👍 |
5213d3f
to
0305dbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Copons let's go ahead and add this now. If folks have additional feedback we can follow up in another PR.
Sorry for chiming in late, I was in user interviews. Looks good when testing the steps mentioned in the description. A couple comments:
I think this might be the exact same tooltip that flashes in (1). Same thing happens if I head over to the Reader: Also, If I navigate to the Customizer, the first tooltip is still floating on the page: |
@lsinger are the ^^ known issues with guided tours, or do we have anything else we should configure? |
I think I should limit that step to only the paths with the sidebar visible (e.g. |
Some thoughts:
|
When you hit a valid route as a logged-out user, we should send you to the login page with a redirect back to the page you were trying to access. This is how all wp-admin links in core WP works. There have been fixes for individual pages (eg #24687 ) but this should be handled at the framework level. We have an email campaign using the Simple Payments Guided Tour #24627 and it freezes at a blank screen for a logged-out user. What this change does is to do a redirect for a valid section with the `enableLoggedOut` property set to true to the login screen with a redirect. A future PR could probably remove all bespoke uses of `import { redirectLoggedOut } from 'controller'` as well since this should supersede it.
Close #24594
Add a new Simple Payments tour that is supposed to be triggered by a direct link (
/?tour=simplePaymentsEmailTour
) from the Simple Payments email.Testing Instructions
/stats/day/{site}
and make sure it doesn't open thesimplePaymentsEmailTour
guided tour./stats/day/{site}?tour=simplePaymentsEmailTour
.