Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guided Tours: Add Simple Payments Email Tour #24627

Merged
merged 6 commits into from
May 3, 2018

Conversation

Copons
Copy link
Contributor

@Copons Copons commented May 2, 2018

Close #24594

Add a new Simple Payments tour that is supposed to be triggered by a direct link (/?tour=simplePaymentsEmailTour) from the Simple Payments email.

Testing Instructions

  • Open /stats/day/{site} and make sure it doesn't open the simplePaymentsEmailTour guided tour.
  • Open /stats/day/{site}?tour=simplePaymentsEmailTour.
  • Make sure the first step of the tour is displayed correctly, and it points to the Add Page sidebar button.
  • Add a new page, which will open the Editor.
  • Make sure the second and last step of the tour is displayed correctly, and it points to the Add Content toolbar button.

@matticbot
Copy link
Contributor

@Copons Copons self-assigned this May 2, 2018
@Copons Copons requested a review from a team May 2, 2018 16:19
@Copons Copons added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 2, 2018
@gwwar gwwar requested review from a team and jancavan May 2, 2018 17:01
@gwwar
Copy link
Contributor

gwwar commented May 2, 2018

The tour works as advertised, but it looks like there's 2 other simple payment tours. One in examples and another that appears to be in use.

@lsinger what is the suggested maintenance approach here? We want to run another email campaign with a tour. Should we reuse the old tour, as the query param will force the tour to start?

@gwwar
Copy link
Contributor

gwwar commented May 2, 2018

@jancavan, @apeatling and I noted that we can probably drop the step 3, where we note that you added a payment button, since the user can see that in the editor directly.

Step 2 is a little awkward too in that the tour needs to be dismissed manually, but I feel tempted to click on the add dropdown first. If that's the case, the tour sits underneath the dropdown. We probably don't need to address this here, since I think it's a tour quirk, but wanted to note it.

screen shot 2018-05-02 at 7 24 34 pm

@lsinger
Copy link
Contributor

lsinger commented May 3, 2018

@gwwar I'd tend to do a new tour, since none of the previous ones were used for an email campaign. Content-wise they might be similar or even the same, but there's value in keeping intentions separate, too, in my opinion.

@gwwar
Copy link
Contributor

gwwar commented May 3, 2018

39476466-4f4c7628-4d5c-11e8-8dac-aca5043806b2

In step 1, we have a continue button here which isn't quite right for this case since, the next step is to click on add vs showing the next tip on the same page. I think we need to remove the continue button (what the branch has currently) and add a call to action, probably an explicit sentence to click on the Page add button. We can see a similar pattern in other main tours.

After this is done I believe we can 🚢. @lsinger is it enough here to guard the display of this tour with a noop for the when value?

cc @jancavan

@lsinger
Copy link
Contributor

lsinger commented May 3, 2018

is it enough here to guard the display

Yes, @Copons had already reached out about this on Slack. 👍

@Copons Copons force-pushed the add/guided-tours/simple-payments branch from 5213d3f to 0305dbd Compare May 3, 2018 15:29
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Copons let's go ahead and add this now. If folks have additional feedback we can follow up in another PR.

For future reference here's what step 1 now looks like:
screen shot 2018-05-03 at 6 27 33 pm

@Copons Copons merged commit 6dd5b62 into master May 3, 2018
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 3, 2018
@Copons Copons deleted the add/guided-tours/simple-payments branch May 3, 2018 16:49
@jancavan
Copy link
Contributor

jancavan commented May 3, 2018

Sorry for chiming in late, I was in user interviews. Looks good when testing the steps mentioned in the description. A couple comments:

  1. This is minor, but I see a tooltip that flashes on the left-hand corner immediately after adding a Page.
  2. If I add a Post instead, the tooltip in the first step is displayed on the upper left:

screen shot 2018-05-03 at 12 41 34 pm

I think this might be the exact same tooltip that flashes in (1).

Same thing happens if I head over to the Reader:

screen shot 2018-05-03 at 12 48 04 pm

Also, If I navigate to the Customizer, the first tooltip is still floating on the page:

screen shot 2018-05-03 at 12 45 49 pm

@gwwar
Copy link
Contributor

gwwar commented May 3, 2018

@lsinger are the ^^ known issues with guided tours, or do we have anything else we should configure?

@Copons
Copy link
Contributor Author

Copons commented May 4, 2018

I think I should limit that step to only the paths with the sidebar visible (e.g. /pages, but not /page, etc.).

@lsinger
Copy link
Contributor

lsinger commented May 4, 2018

Some thoughts:

  • Guided Tours has a mechanism to prematurely quit a tour if we detect that the user is trying to move away from it. It's an imperfect heuristic and in this case it might not be firing. We tried to err on the side of allowing the user to continue the tour (rather have a few more false negatives than false positives with regards to exit intent detection).
  • The post / page editor difference might just be a question of giving the target a selector that's generic enough / works on both pages. Also note that visual vs. html editor might make a difference regarding what nodes are a) findable and b) visible.
  • Guided Tours will quit if it can't find a target element. Either this is failing here or it can find the target but it's hidden and / or offscreen.

mattwiebe added a commit that referenced this pull request Jun 14, 2018
When you hit a valid route as a logged-out user, we should send you to the login page with a redirect back to the page you were trying to access. This is how all wp-admin links in core WP works.

There have been fixes for individual pages (eg #24687 ) but this should be handled at the framework level. We have an email campaign using the Simple Payments Guided Tour #24627 and it freezes at a blank screen for a logged-out user.

What this change does is to do a redirect for a valid section with the `enableLoggedOut` property set to true to the login screen with a redirect. A future PR could probably remove all bespoke uses of `import { redirectLoggedOut } from 'controller'` as well since this should supersede it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants