Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test summary reliability #2543

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Fix test summary reliability #2543

merged 2 commits into from
Mar 7, 2025

Conversation

martincostello
Copy link
Member

Avoid write conflicts when adding the coverage to the GITHUB_STEP_SUMMARY.

Bonus improvement of readability too.

Cherry-picked from #2531 where the addition of the net10.0 made it too likely to always happen.

Attempt to fix write conflicts when adding the coverage to the `GITHUB_STEP_SUMMARY`.
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (284acee) to head (6d3d4e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2543   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7327           
  Branches     1013     1013           
=======================================
  Hits         7051     7051           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martincostello martincostello disabled auto-merge March 7, 2025 15:50
Use `AppendAllLines()` not `WriteAllLines()`.
@martincostello martincostello enabled auto-merge (squash) March 7, 2025 15:58
@martincostello martincostello changed the title Fix test summary reliabilty Fix test summary reliability Mar 7, 2025
@martincostello martincostello disabled auto-merge March 7, 2025 15:58
@martincostello martincostello enabled auto-merge (squash) March 7, 2025 15:58
@martincostello martincostello merged commit 08b3c0f into main Mar 7, 2025
26 checks passed
@martincostello martincostello deleted the more-reliable-coverage branch March 7, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant