Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration to not log commands #10537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BnDLett
Copy link
Contributor

@BnDLett BnDLett commented Mar 7, 2025

Especially given that some servers or plugins may have commands that they don't want to have logged. Such as this plugin.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

Especially given that some servers or plugins may have commands that
they don't want to have logged.
@JasonP01
Copy link
Contributor

JasonP01 commented Mar 7, 2025

In CN we used menus with commands as those arent logged to console, very helpful with keeping account login information outside the console logs

@BnDLett
Copy link
Contributor Author

BnDLett commented Mar 7, 2025

In CN we used menus with commands as those arent logged to console, very helpful with keeping account login information outside the console logs

Is there a way to get text from a menu via a server-side plugin? I didn't see a way when I was looking through Call.

@JasonP01
Copy link
Contributor

JasonP01 commented Mar 7, 2025

Is there a way to get text from a menu via a server-side plugin? I didn't see a way when I was looking through Call.

Thats how we do it yes, check out xpdustry/imperium and our AccountCommand.kt file in the mindustry directory, i think thats where login is (you can search for it to)

@JasonP01
Copy link
Contributor

JasonP01 commented Mar 7, 2025

We use distributor framework for our menus but its possible in vanilla with some engineering

@1ue999
Copy link
Contributor

1ue999 commented Mar 8, 2025

In CN we used menus with commands as those arent logged to console, very helpful with keeping account login information outside the console logs

Is there a way to get text from a menu via a server-side plugin? I didn't see a way when I was looking through Call.

you can use Call.textInput (or smth)

@BnDLett
Copy link
Contributor Author

BnDLett commented Mar 8, 2025

That's certainly useful. Danke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants