Weapon Refactoring #10534
Draft
Weapon Refactoring #10534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also correct shooting
|
While you're at it, why not also remove that odd default x value of 5? I believe dagger only uses it, so it's been a slightly inconvenient value that do just exist. |
What about the default shootY of 3? |
|
In the process, I've discovered that all the missiles have had the default x value on their weapons, meaning their explosions have been offset the entire time.
|
BlueTheCube
reviewed
Mar 7, 2025
| @@ -488,8 +488,7 @@ private void rebuildBrowser(){ | |||
| for(ModListing mod : listings){ | |||
| if(((mod.hasJava || mod.hasScripts) && Vars.ios) || | |||
| (!Strings.matches(searchtxt, mod.name) && !Strings.matches(searchtxt, mod.repo)) | |||
| //hack, I'm basically testing if 135.10 >= modVersion, which is equivalent to modVersion >= 136 | |||
| || (Version.isAtLeast(135, 10, mod.minGameVersion)) | |||
| || (Version.isAtLeast(147, 0, mod.minGameVersion)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors weapons into not being an unreadable mess.
BaseWeaponBuildWeaponMineWeaponTargetWeaponRepairBeamWeaponReloadWeaponPointDefenseWeaponWeaponContinuousWeaponShould retain Json mod backwards compatability.
Java mods will need to be updated.
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: