Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DappError with JsonRpcError #6456

Closed
oa-s opened this issue Mar 3, 2023 · 0 comments · Fixed by #6457
Closed

Replace DappError with JsonRpcError #6456

oa-s opened this issue Mar 3, 2023 · 0 comments · Fixed by #6457

Comments

@oa-s
Copy link
Contributor

oa-s commented Mar 3, 2023

reason why this needed:

some dapps like uniswap, want proper error code when error has generated, e.g it wants error code -32603 when method wallet_switchEthereumChain called, and chain not supported on client.
oa-s added a commit that referenced this issue Mar 3, 2023
@oa-s
Replace DappError with JsonRpcError #6456
4e92280
This was referenced Mar 3, 2023
Merged
Closed
oa-s added a commit that referenced this issue Mar 5, 2023
@oa-s
Replace DappError with JsonRpcError #6456
796d241
hboon added a commit that referenced this issue Mar 6, 2023
@hboon
Merge pull request #6457 from AlphaWallet/#6456

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f405115 
Replace DappError with JsonRpcError #6456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace DappError with JsonRpcError #6456 AlphaWallet/alpha-wallet-ios
1 participant
@oa-s