Caller now can now pass error as string (old behavior) or dictionary #39
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hboon
commented
Mar 5, 2023
| @@ -39974,7 +39974,7 @@ var AlphaWallet = { | |||
| var callback = callbacks[id]; | |||
|
|
|||
| if (callback.isRPC) { | |||
| var response = { 'id': id, jsonrpc: '2.0', result: value, error: { message: error } }; | |||
| var response = { 'id': id, jsonrpc: '2.0', result: value, error: error }; | |||
There was a problem hiding this comment.
@oa-s is it better to check error if it's just a string and keep the old behavior?
if error is string //I forgot my JavaScript
error: { message: error }
else
error: error
end
oa-s
approved these changes
Mar 5, 2023
| @@ -39974,7 +39974,7 @@ var AlphaWallet = { | |||
| var callback = callbacks[id]; | |||
|
|
|||
| if (callback.isRPC) { | |||
| var response = { 'id': id, jsonrpc: '2.0', result: value, error: { message: error } }; | |||
| var response = { 'id': id, jsonrpc: '2.0', result: value, error: error }; | |||
…an now also pass a dictionary instead
hboon
force-pushed
the
caller-now-needs-to-pass-in-error-dictionary-instead-of-just-a-string-message
branch
from
e21ccf1 to
2a1121c
Compare
|
Force-pushed so the error passed to the callback can be a string (old behavior) as well as a dictionary |
hboon
changed the title
hboon
deleted the
caller-now-needs-to-pass-in-error-dictionary-instead-of-just-a-string-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #38