eth_signTypeData_v3 hook for EIP712 #12
Closed
+15
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JamesSmartCell did you change the regular dist file then minify? |
|
Yes. Is that how it should be done? Or is there a better process? |
That is the right way (technically the builder should work but it doesn't) just wanted to clarify because checking the diff in the min file is very difficult |
Understatement of the year :) |
bitcoinwarrior1
approved these changes
Aug 28, 2020
|
Superseded by #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the EIP712 signing hook to the AlphaWallet dist.
See article here:
https://medium.com/metamask/eip712-is-coming-what-to-expect-and-how-to-use-it-bb92fd1a7a26
in particular the new hook
eth_signTypedData_v3.I will create a separate issue for iOS with an in-depth 'How-To' for EIP712 and legacy EIP712 (
eth_signTypeData), both standards are in use and we should support them.