feature: add restart skeleton #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letty5411
force-pushed
the
restartdev
branch
2 times, most recently
from
f5952a7 to
408f1a8
Compare
pouchrobot
added
size/L
conflict/needs-rebase
and removed
size/M
conflict/needs-rebase
labels
|
conflicted, please rebase you code ,thanks :) @Letty5411 |
HusterWan
reviewed
Mar 16, 2018
cli/restart.go
Outdated
| } | ||
|
|
||
| // runrestart is the entry of restart command. | ||
| func (rc *RestartCommand) runrestart(args []string) error { |
cli/restart.go
Outdated
| // restartCommand uses to implement 'restart' command, it restarts a container. | ||
| type RestartCommand struct { | ||
| baseCommand | ||
| time int |
There was a problem hiding this comment.
s/time/timeout will be more reasonable, WDYT?
|
@Letty5411 Maybe we also need add a skeleton of ci test, WDYT? |
HusterWan
reviewed
Mar 16, 2018
cli/restart.go
Outdated
| // restartDescription is used to describe restart command in detail and auto generate command doc. | ||
| var restartDescription = "restart one or more containers" | ||
|
|
||
| // restartCommand uses to implement 'restart' command, it restarts a container. |
There was a problem hiding this comment.
s/restartCommand/RestartCommand
BTW, as your restartDescription says restart one or more containers, so this comment should change
Signed-off-by: letty <[email protected]>
|
ping @Letty5411 CI fails according integration system. If this is flaky test, welcome to track this with profiling an issue. build url: https://travis-ci.org/alibaba/pouch/builds/354139016 |
Letty5411
changed the title
|
LGTM |
|
This PR is not the reason CI failed, so I will merge this PR |
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: letty [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews