bugfix: fix update container rootfs disk quota recursively timeout #2922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating disk quota to a running container will set quota ID to all files
and directories under UpperDir in function SetQuotaForDir, which will
take a long while. Because it will costs much time in
getMountpointFstype, CheckRegularFile and filepath.Walk.
Call SetQuotaForDir Asynchronously when updating disk quota .
Signed-off-by: Wang Rui [email protected]
Ⅰ. Describe what this PR did
This patch will optimize efficiency of updating disk quota. It may take a long while in function SetQuotaForDir if container has a lot of new files and directories in UpperDir.
So we can change to call SetQuotaForDir in go routine.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
step 1. Run many containers with disk quota so that /proc/mounts has a lot of lines
step 2. Make a running container create many files and directories.
step3. Before this path, update disk quota of this container will take a log while. After this path, it will be more efficient.
Ⅴ. Special notes for reviews