copy: should not mount rootfs again #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the copy command, we need to copy thing into container. But we can't mount/umount the rootfs again, because it will impact /home and /tmp in running container. Align with moby behaviour, we use the host rootfs directly for running container without mount/unmount. Signed-off-by: Wei Fu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2899 +/- ##
===========================================
- Coverage 68.9% 52.74% -16.17%
===========================================
Files 291 291
Lines 18251 18238 -13
===========================================
- Hits 12576 9619 -2957
- Misses 4222 7395 +3173
+ Partials 1453 1224 -229
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
for the copy command, we need to copy thing into container. But we can't
mount/umount the rootfs again, because it will impact /home and /tmp in
running container. Align with moby behaviour, we use the host rootfs
directly for running container without mount/unmount.
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews