Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test Added for DetachVolume Method #1881

Closed
wants to merge 3 commits into from
Closed

Unit Test Added for DetachVolume Method #1881

wants to merge 3 commits into from

Conversation

sunzeyucmu
Copy link

@sunzeyucmu sunzeyucmu commented Jul 24, 2018 •
edited
Loading

Ⅰ. Describe what this PR did

Unit Test Added for DetachVolume Method

Ⅱ. Does this pull request fix one issue?

#1761

Ⅲ. Describe how you did it

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Group 1

@pouchrobot
Copy link
Collaborator

@sunzeyucmu Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @sunzeyucmu
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @sunzeyucmu
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@sunzeyucmu sunzeyucmu changed the title Dev Unit Test Added for DetachVolume Method Jul 24, 2018
HusterWan
HusterWan reviewed Jul 24, 2018
View reviewed changes
storage/volume/core_test.go
driver.Register(driver.NewFakeDriver(driverName))
defer driver.Unregister(driverName)

v, err1 := core.CreateVolume(volid0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first attach a volume then detach it

@pouchrobot
Copy link
Collaborator

ping @sunzeyucmu
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@HusterWan HusterWan closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HusterWan HusterWan HusterWan left review comments

Assignees
No one assigned
Labels
areas/storage areas/test conflict/needs-rebase size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunzeyucmu @pouchrobot @HusterWan