Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev jiapeng baiji-group-264-3 #1790

Closed

Conversation

jiapengcs
Copy link
Contributor

@jiapengcs jiapengcs commented Jul 23, 2018

Ⅰ. Describe what this PR did

add unit-test for ListVolumeName #1763

Ⅱ. Does this pull request fix one issue?

fixes #1763

Ⅲ. Describe how you did it

implement function ListVolumeName in core_test.go

Ⅳ. Describe how to verify it

unit test, run go test -test.run ListVolumeName

Ⅴ. Special notes for reviews

function ListVolumeName() depends on ListVolumes(), and expect to get the filtered name list. However, function ListVolumes() doesn't implement filtering operation, neither does ListVolumeName().

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @jiapengcs
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot pouchrobot added size/S and removed size/M labels Jul 23, 2018
@pouchrobot
Copy link
Collaborator

@jiapengcs Thanks for your contribution. 🍻
Please sign off in each of your commits.

@codecov-io
Copy link

Codecov Report

Merging #1790 into master will decrease coverage by 9.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1790      +/-   ##
==========================================
- Coverage    56.3%   47.04%   -9.27%     
==========================================
  Files         200      200              
  Lines       15657    15657              
==========================================
- Hits         8816     7366    -1450     
- Misses       5745     7393    +1648     
+ Partials     1096      898     -198
Flag Coverage Δ
#critest 16.04% <ø> (-17.44%) ⬇️
#integrationtest 37.67% <ø> (+0.01%) ⬆️
#unittest 20.37% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri_stream.go 0% <0%> (-80%) ⬇️
cri/v1alpha2/server.go 0% <0%> (-79.85%) ⬇️
daemon/containerio/streams.go 20.68% <0%> (-79.32%) ⬇️
cri/v1alpha2/service/cri.go 0% <0%> (-73.34%) ⬇️
daemon/containerio/cri_log_file.go 11.76% <0%> (-72.55%) ⬇️
cri/stream/runtime.go 0% <0%> (-71.02%) ⬇️
cri/stream/portforward/httpstream.go 0% <0%> (-69.17%) ⬇️
cri/stream/remotecommand/attach.go 0% <0%> (-66.67%) ⬇️
cri/v1alpha2/cri.go 0% <0%> (-65.97%) ⬇️
cri/stream/httpstream/spdy/connection.go 0% <0%> (-58%) ⬇️
... and 26 more

@jiapengcs jiapengcs closed this Jul 23, 2018
@jiapengcs jiapengcs deleted the dev-jiapeng branch July 23, 2018 19:52
@jiapengcs jiapengcs restored the dev-jiapeng branch July 23, 2018 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for ListVolumeName
4 participants