Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTest for TestListVolumeName() And TestUseProxy() And TestDetachVolume() #1785

Closed
wants to merge 2 commits into from

Conversation

zhengshiqiang47
Copy link

Ⅰ. Describe what this PR did

add UnitTest for TestListVolumeName() And TestUseProxy() And TestDetachVolume()

Ⅱ. Does this pull request fix one issue?

fixes #1760 #1761 #1763

Ⅲ. Describe how you did it

add unitTest

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

baiji group five

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2018

CLA assistant check
All committers have signed the CLA.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @zhengshiqiang47
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@afc7a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1785   +/-   ##
=========================================
  Coverage          ?   56.64%           
=========================================
  Files             ?      200           
  Lines             ?    15657           
  Branches          ?        0           
=========================================
  Hits              ?     8869           
  Misses            ?     5693           
  Partials          ?     1095
Flag Coverage Δ
#critest 33.53% <ø> (?)
#integrationtest 37.56% <ø> (?)
#unittest 20.75% <ø> (?)

add image_proxy_util test
@pouchrobot
Copy link
Collaborator

@zhengshiqiang47 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@fuweid fuweid closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for proxy/useProxy
5 participants