bugfix: container cannot start after first start failed

daemon/mgr/container.go

@@ -657,39 +657,35 @@ func (mgr *ContainerManager) createContainerdContainer(ctx context.Context, c *C
 		s.Process.Terminal = true
 	}
 
-	err = mgr.Client.CreateContainer(ctx, &ctrd.Container{
+	if err := mgr.Client.CreateContainer(ctx, &ctrd.Container{
 		ID:      c.ID(),
 		Image:   c.Image(),
 		Runtime: c.meta.HostConfig.Runtime,
 		Spec:    s,
 		IO:      io,
-	})
-	if err == nil {
-		c.meta.State.Status = types.StatusRunning
-		c.meta.State.StartedAt = time.Now().UTC().Format(utils.TimeLayout)
-		pid, err := mgr.Client.ContainerPID(ctx, c.ID())
-		if err != nil {
-			return errors.Wrapf(err, "failed to get PID of container: %s", c.ID())
-		}
-		c.meta.State.Pid = int64(pid)
-		c.meta.State.ExitCode = 0
+	}); err != nil {
+		logrus.Errorf("failed to create new containerd container: %s", err.Error())
 
-		// set Snapshot MergedDir
-		c.meta.Snapshotter.Data["MergedDir"] = c.meta.BaseFS
-	} else {
-		c.meta.State.FinishedAt = time.Now().UTC().Format(utils.TimeLayout)
-		c.meta.State.Error = err.Error()
-		c.meta.State.Pid = 0
-		//TODO: make exit code more correct.
-		c.meta.State.ExitCode = 127
+		// TODO(ziren): markStoppedAndRelease may failed
+		// we should clean resources of container when start failed
+		_ = mgr.markStoppedAndRelease(c, nil)
+		return err
+	}
 
-		// release io
-		io.Close()
-		mgr.IOs.Remove(c.ID())
+	// Create containerd container success.
+	c.meta.State.Status = types.StatusRunning
+	c.meta.State.StartedAt = time.Now().UTC().Format(utils.TimeLayout)
+	pid, err := mgr.Client.ContainerPID(ctx, c.ID())
+	if err != nil {
+		return errors.Wrapf(err, "failed to get PID of container %s", c.ID())
 	}
+	c.meta.State.Pid = int64(pid)
+	c.meta.State.ExitCode = 0
 
-	c.Write(mgr.Store)
-	return err
+	// set Snapshot MergedDir
+	c.meta.Snapshotter.Data["MergedDir"] = c.meta.BaseFS
+
+	return c.Write(mgr.Store)
 }
 
 // Stop stops a running container.

docs/kubernetes/pouch_with_kubernetes_deploying.md

@@ -37,7 +37,8 @@ An all-in-one kubernetes cluster with pouch runtime could be deployed by running
 hack/kubernetes/allinone.sh
 
 ```
-Please refer to https://github.com/alibaba/pouch/blob/master/hack/kubernetes/allinone.sh .
+
+Please refer to [allinone](https://github.com/alibaba/pouch/blob/master/hack/kubernetes/allinone.sh) .
 
 ### Install Pouch