Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug while creating index name #40

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

rralcala
Copy link
Contributor

@rralcala rralcala commented Oct 10, 2019

The wrong variable was used to generate the index name, fixed and added a test to prevent it in the future.
This should fix #39

@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #40 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #40      +/-   ##
=========================================
+ Coverage   51.95%   52.3%   +0.34%     
=========================================
  Files          24      24              
  Lines        1434    1434              
=========================================
+ Hits          745     750       +5     
+ Misses        625     620       -5     
  Partials       64      64
Impacted Files Coverage Δ
common/elasticsearch/elasticsearch.go 49.61% <100%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bf68b...6f72222. Read the comment docs.

@ringtail ringtail merged commit 03a3e2b into AliyunContainerService:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES Parameter problem
3 participants