-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README with new battery thresholds feature #644
Conversation
Some thing you will want to add is the stop charge threshold can not be below 65 ( at least with thinkpad_acpi ) I've had errors having it lower than 65 Edit: I'll try this test again just to make sure |
Hm, I can't find any documentation on this, so maybe this needs to be explored further? |
I started building a test however I won't be able to finish it until tonight I'll reply back with results |
So it seems my test is working without issue so I'm going to do some investigating |
Maybe it would also be a good idea to first merge #645 ? |
Agreed. |
#645 merged, added a few comments, nothing major other then that LGTM! Let's wait for @PurpleWazard to finish with:
and if he doesn't have any additional comments we're ready to merge. |
It all looks good to me @AdnanHodzic suggested that we clarify that --live doesn't call the battery functions. I can add that change before or after the new release if needed |
@PurpleWazard I would rather have it before and hence part of 2.2.0 release. |
It is done |
Removed this comment because this is now addressed with merge of #646
@shadeyg56 then let's add those 2 links I suggested and it's ready to merge. |
LGTM, thank you for your contribution will make sure to make this PR as part of release notes for 2.2.0. |
* README: add battery threshold sections * README: link to version
Apologies for the mess in the last attempt I made lol. The rebase went horribly wrong.
Added a new section for the battery thresholds as discussed in #637