Improve charging detection function #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of items in power_supply is now sorted. This way the AC is 'always' on top, and checked first. What I noticed is that internal supplies are always use uppercase, and inserted devices all use lowercase.
So if this theory is correct the AC and internal battery will always be checked first.
I also noticed the "scope" file under the hid device with battery. Maybe that file could help identify if an battery is from some other device or not. Will see in future bug reports if that is correct and maybe use that.
If this still not works correctly I've implement an ignorelist. Where we can easily add items or parts of the string from devices we want to be ignored.
Currently in the ignore list is the "hidpp_battery" that came up in every issue so far.
It's just an improvement of what we already have.
Fixes #331