Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the dependency handling #88

Merged
merged 4 commits into from
Sep 12, 2017
Merged

Changed the dependency handling #88

merged 4 commits into from
Sep 12, 2017

Conversation

fschoell
Copy link
Contributor

I had multiple issues with dependencies again, so I decided to fix our dependency handling. This is the PR that includes:

  • Added a npm-shrinkwrap.json which saves the state of the node_modules folder and will be used by npm install instead of the package.json. This insures that we all are working with the same version of all installed packages (even of their dependencies). After an dependency upgrade, just run npm shrinkwrap to update the shrinkwrap file. In future this might be replaced by package-lock.json which is generated by the latest npm version automatically, however this still has some bugs and shrinkwrap is backward compatible to older npm versions, too.
  • Changed the version handling to only update to minor versions (using ~ instead of ^)
  • Updated dependencies
  • Pinned the zone.js version due to a bug, see Overview of pinned dependency versions and workarounds #86

@fschoell fschoell requested a review from sleidig July 26, 2017 17:00
@fschoell
Copy link
Contributor Author

@sleidig those changes are only dependency updates and refactoring, so as long as you don't get any issues with those dependencies it's fine to merge (despite of the amount of changes).

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and runs. Thanks for the cleanup.

@sleidig sleidig merged commit 2a7659d into master Sep 12, 2017
@sleidig sleidig deleted the dependency_update branch September 12, 2017 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants